Update base image to alpine:latest #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sad that this won't be merged, works great. |
tigerblue77
approved these changes
Dec 2, 2022
|
I added this to my fork. By the way, you don't have to add latest, if you don't specify a tag, it defaults to latest DockerHub: https://hub.docker.com/r/upagge/samba |
YSHKatN
added a commit
to YSHKatN/samba
that referenced
this pull request
Mar 12, 2023
Is your fork a drop-in replacement for the original dperson/samba image? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the base image to be alpine:latest ensuring the latest version of Alpine is always used.
This is important because older versions of Alpine no longer receive security updates. The version that was last built and pushed to docker hub contains a number of critical security vulnerabilities.
Additionally, I have removed the -S flag and replaced it with --debug-stdout from the smbd command in samba.sh because it is not supported in version 4.15.7 which is current for Alpine Linux 3.16.2. This was the minimum change required to get the container to run with the latest version of Alpine Linux.