-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SD-558]updated help text and change labels #566
Merged
yeniatencio
merged 18 commits into
develop
from
feature/SD-558-control-page-header-display
Jan 8, 2025
Merged
[SD-558]updated help text and change labels #566
yeniatencio
merged 18 commits into
develop
from
feature/SD-558-control-page-header-display
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeniatencio
assigned sharmasahil and anthony-malkoun and unassigned sharmasahil and anthony-malkoun
Dec 24, 2024
vincent-gao
approved these changes
Dec 30, 2024
@yeniatencio ready for test. once the tests pass and approval is received from Jess, it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SD-558 and https://digital-vic.atlassian.net/browse/SD-22
Testing link: https://nginx-php.pr-1759.content-vic.sdp4.sdp.vic.gov.au/
Problem/Motivation
This PR is covering aceptance criteria from the tickets mentioned above.
‘Light’ to ‘Default’
‘Dark’ to ‘Reverse blocked text’
Scenarios:
Note: Previous PR from ticket SD-22 is not needed anymore as this PR is covering that.
Fix
Related PRs
Screenshots
TODO