Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-558]updated help text and change labels #566

Merged
merged 18 commits into from
Jan 8, 2025

Conversation

yeniatencio
Copy link
Contributor

@yeniatencio yeniatencio commented Dec 17, 2024

Jira

https://digital-vic.atlassian.net/browse/SD-558 and https://digital-vic.atlassian.net/browse/SD-22
Testing link: https://nginx-php.pr-1759.content-vic.sdp4.sdp.vic.gov.au/

Problem/Motivation

This PR is covering aceptance criteria from the tickets mentioned above.

  1. Rename ‘hero image theme’ field to ‘Page title display style’
  2. Change the drop down options to:
    ‘Light’ to ‘Default’
    ‘Dark’ to ‘Reverse blocked text’
  3. Update help text to display below the field.
  4. Move the field to display after ‘Header styles’ on the Landing page content type
    Scenarios:
  • Corner graphics - Default + Reverse blocked text (Both options available and by default "Default" should be selected)
  • Full background image - Reverse blocked text only (Only one option should be set)
  • CTA - Default only (Only one option should be set)
  • Default appearance - Default only (Only one option should be set)
    Note: Previous PR from ticket SD-22 is not needed anymore as this PR is covering that.

Fix

Related PRs

Screenshot 2024-12-24 at 12 28 09 pm
Screenshot 2024-12-24 at 12 28 01 pm
Screenshot 2024-12-24 at 12 27 53 pm
Screenshot 2024-12-24 at 12 27 45 pm

Screenshots

TODO

@vincent-gao
Copy link
Contributor

@yeniatencio ready for test. once the tests pass and approval is received from Jess, it can be merged.

@yeniatencio yeniatencio merged commit f3a0ee4 into develop Jan 8, 2025
1 check passed
@yeniatencio yeniatencio deleted the feature/SD-558-control-page-header-display branch January 8, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants