Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDS-1263] Added phpdbg binary. #124

Merged
merged 1 commit into from
Aug 17, 2022
Merged

[DDS-1263] Added phpdbg binary. #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bay/images/Dockerfile.builder
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
FROM uselagoon/php-7.4-cli-drupal:latest
ARG PHP_VERSION=7.4
FROM php:${PHP_VERSION}-cli-alpine AS php-cli
FROM uselagoon/php-${PHP_VERSION}-cli-drupal:latest
COPY --from=php-cli /usr/local/bin/phpdbg /usr/local/bin/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're not treating this as a dependency rather than an upstream copy?

RUN apk add --update --no-cache \
    php-phpdbg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well initially I naively thought that I couldn't add phpdbg using a pkg manager because it's a system API and not a PHP extension.

Turns out that's not the case but the complication to changing to your suggestion is that it installs the php 8 version of the module because the Alpine repos set in the build process don't use the edge branch. So implementing the suggestion would require that to change.

It feels simpler to copy the binary but what's your preference?

ARG GOJQ_VERSION=0.12.4

ENV WEBROOT=docroot \
Expand Down