[DDS-1263] Added phpdbg binary. #124
Conversation
GROwen
requested review from
steveworley,
MdNadimHossain,
nicksantamaria and
santhureturi308
There was a problem hiding this comment.
worked for me. So fine from my side -
I have ran this ci job using this image PR and it worked
| ARG PHP_VERSION=7.4 | ||
| FROM php:${PHP_VERSION}-cli-alpine AS php-cli | ||
| FROM uselagoon/php-${PHP_VERSION}-cli-drupal:latest | ||
| COPY --from=php-cli /usr/local/bin/phpdbg /usr/local/bin/ |
There was a problem hiding this comment.
Any reason we're not treating this as a dependency rather than an upstream copy?
RUN apk add --update --no-cache \
php-phpdbg
There was a problem hiding this comment.
Well initially I naively thought that I couldn't add phpdbg using a pkg manager because it's a system API and not a PHP extension.
Turns out that's not the case but the complication to changing to your suggestion is that it installs the php 8 version of the module because the Alpine repos set in the build process don't use the edge branch. So implementing the suggestion would require that to change.
It feels simpler to copy the binary but what's your preference?
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Changelog Entry
Changes
Added binary for phpdbg after it was removed from the upstream used for uselagoon images.