Add stats #275
Add stats #275
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
from the preview link above, it seems that the new stats endpoint isn't accessible? it's working locally for me, so I'm not sure what the cause might be |
|
Hey thanks for this PR! Love the idea, I'll take a look. The vercel preview is frontend-only, so it makes sense that your server-side changes aren't reflected. |
|
At first glance things look good -- maybe can add # players to History? + whether the game is in-progress or solved (and change the link to /replay/gid if it's completed) |
|
I also was interested in getting the player count! But I was finding that the backend isn't aware of multiple users, where game_events don't actually have a user populated on them. Could you give me some pointers here? If you'd prefer this, I can definitely rework things to handle incomplete games. My original thinking was that "stats" would only be useful for complete games, and https://downforacross.com/?complete=0&in_progress=1&new=0 could be used to see incomplete games. What do you think? I updated all the links to the replay link! |
src/pages/Stats.tsx
Outdated
| }, []); | ||
| user.listUserHistory().then((history: any) => { | ||
| console.log(`keys: ${_.keys(history)}`); | ||
| fetchStats({gids: _.keys(history)}).then((s) => { |
There was a problem hiding this comment.
can we cap this at like, last 500 games? i'm not an expert in database performance but i'm worried that the backend could get slow if we try to do too many at once since the query involves joining with the game_events table (and there's no index on game event type afaik)
src/components/common/Nav.js
Outdated
| className="molester-moon" | ||
| style={darkModePreference !== '0' ? {opacity: 1} : {}} | ||
| onClick={toggleMolesterMoons} | ||
| > | ||
| Dark Mode (beta): {darkModePreferenceText(darkModePreference)} | ||
| </div> | ||
| <div> | ||
| <a href="/stats">Stats</a> |
There was a problem hiding this comment.
could we style this a bit differently? On my computer it becomes purple after clicked which is a bit hard to see. Just making it white w/ underline is probably fine.
and name the link "Your Stats" or something so it's not confused with global site stats
one final thing i noticed is that the secret dark mode button's text kinda overlaps with this, so maybe we need some margin-left (maybe 40px?)
|
i checked this out locally and it looks great! i left some small nitpicky comments inline, happy to merge after those are addressed. as a follow-up after this is merged, i think it'd be a good idea to do a backfill and eagerly store & maintain the stats in the db to avoid having to do expensive queries. this would also allow us to track stats like number of distinct users + anything else we want to include in the stats page (there may be user feedback that we can act on). |
|
I think I made all your suggested changes! and added another log line to help measure the performance of the endpoint. another index that might be good would be on puzzle_solves prefixed with gid rather than pid idk what your database maintenance looks like, but yeah would be happy to help. when marking a puzzle solve, we could probably record the revealed/checked count. I wonder what stats other users would want (filtering different conditions, per time period, longest/current streak, day-of-week stats), and user feedback + performance could tell us what to improve |
|
great, thanks! merging this, i'll try to keep an eye on performance but not overly worried for now since there's limits on how many games are considered at once for stats |
Similar to #247, I thought it could be helpful to see the times of one's previous solves. As far as I could tell, the stats modules weren't used, so I repurposed them for this.
Let me know what you think!