New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now using clipboard API + Added feedback #7

Open

guaiamum wants to merge 1 commit into dovy:master from guaiamum:master

guaiamum commented Sep 23, 2019

Closes Feature Request - Clipboard API #6
Now using Clipboard API (https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API)
Added feedback animation for error and content copied


          now using clipboard API, added feedback for error and content copied

4ee78cb

Owner

dovy commented Sep 24, 2019

Will this work for all browsers? Don't want to code something that breaks the rest. ;)

Author

guaiamum commented Sep 24, 2019

The clipboard API is quite recent, but should work on most main browsers. https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API#Browser_compatibility

I could add a polyfill with the old approach. How about make it into a Vue component that deals with it all?

Owner

dovy commented Sep 24, 2019

Looks like not IE at all. Let's do a try/catch.

https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API#Browser_compatibility

Author

guaiamum commented Sep 24, 2019

Okay, don't you think is best to encapsulate this logic, Ui and styles into a Vue component, like this official plugin: https://github.com/vuejs/vuepress/tree/master/packages/%40vuepress/plugin-back-to-top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet