Skip to content

Commit

Permalink
Merge pull request #488 from doudar/MIN_ERG_CADENCE
Browse files Browse the repository at this point in the history
MIN_ERG_CADENCE created and changed from 20 to 30.
  • Loading branch information
doudar authored Nov 5, 2023
2 parents f8ceb5a + 5a149fe commit d4ac6c8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Updated communications overview picture.
- Updated kit purchasing links.
- MIN_ERG_CADENCE created and changed from 20 to 30.

### Hardware
- Wire diameter reduced from 7.2mm to 6.0mm on the window passthrough to accommodate the latest batch of cables.
Expand Down
3 changes: 3 additions & 0 deletions include/settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@
// Amount to change watt target per shift in ERG mode.
#define ERG_PER_SHIFT 10

//Minimum cadence where ERG mode stops.
#define MIN_ERG_CADENCE 30

// Default Min Watts to stop stepper.
// This is used to set the lower travel limit for the motor.
#define DEFAULT_MIN_WATTS 50
Expand Down
2 changes: 1 addition & 1 deletion src/ERG_Mode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ void ErgMode::_updateValues(int newCadence, Measurement& newWatts, float newIncl
}

bool ErgMode::_userIsSpinning(int cadence, float incline) {
if (cadence <= 20) {
if (cadence <= MIN_ERG_CADENCE) {
if (!this->engineStopped) { // Test so motor stop command only happens once.
ss2k.motorStop(); // release tension
rtConfig.setTargetIncline(incline - WATTS_PER_SHIFT); // release incline
Expand Down

0 comments on commit d4ac6c8

Please sign in to comment.