Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (events): prefix all new metadata event payloads with “metadata” #2152

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix (events): prefix all new metadata event payloads with “metadata” #2152

merged 2 commits into from
Oct 5, 2023

Conversation

dcvz
Copy link
Contributor

@dcvz dcvz commented Oct 5, 2023 •
edited
Loading

Resolves #2147

@dcvz dcvz requested a review from jspizziri as a code owner October 5, 2023 14:52
puckey
puckey previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@puckey puckey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dcvz dcvz merged commit dcc4e7a into main Oct 5, 2023
4 checks passed
@dcvz dcvz deleted the fix/metadata-payload branch October 5, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puckey puckey puckey left review comments

@jspizziri jspizziri Awaiting requested review from jspizziri jspizziri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with the new metadata events in combination with useTrackPlayerEvents
2 participants
@dcvz @puckey