Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): MetadataTimedReceived payload type #2148

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

puckey
Copy link
Collaborator

@puckey puckey commented Oct 3, 2023

No description provided.

@puckey puckey requested a review from dcvz as a code owner October 3, 2023 12:21
jspizziri
jspizziri previously approved these changes Oct 3, 2023
@dcvz
Copy link
Contributor

dcvz commented Oct 3, 2023

Seem like this was an typo when doing types. One of them is not an array but it should be MetadataCommonReceived instead. MetadataCommonReceived will only return a single dictionary.

@puckey
Copy link
Collaborator Author

puckey commented Oct 3, 2023

Amended the pr to have Event.MetadataCommonReceived be AudioCommonMetadataReceivedEvent instead of AudioCommonMetadataReceivedEvent[]

Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM 👍

@dcvz dcvz merged commit 2b53b88 into doublesymmetry:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants