fix(android): Allow updating duration in notification (#2157)

doublesymmetry · Oct 10, 2023 · e28536c · e28536c
1 parent 4b859e8
commit e28536c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -49,7 +49,7 @@ repositories {
 }
 
 dependencies {
-    implementation 'com.github.doublesymmetry:kotlinaudio:v2.0.0-rc15'
+    implementation 'com.github.doublesymmetry:kotlinaudio:v2.0.0-rc16'
     // used when building against local maven
 //    implementation "com.github.doublesymmetry:kotlin-audio:1.2.2"
 

diff --git a/android/src/main/java/com/doublesymmetry/trackplayer/model/TrackAudioItem.kt b/android/src/main/java/com/doublesymmetry/trackplayer/model/TrackAudioItem.kt
@@ -12,6 +12,6 @@ data class TrackAudioItem(
     override var title: String? = null,
     override var albumTitle: String? = null,
     override val artwork: String? = null,
-    override val duration: Long = -1,
+    override val duration: Long? = null,
     override val options: AudioItemOptions? = null
 ): AudioItem
diff --git a/android/src/main/java/com/doublesymmetry/trackplayer/model/TrackMetadata.kt b/android/src/main/java/com/doublesymmetry/trackplayer/model/TrackMetadata.kt
@@ -14,7 +14,7 @@ abstract class TrackMetadata {
     var album: String? = null
     var date: String? = null
     var genre: String? = null
-    var duration: Long = 0
+    var duration: Long? = null
     var rating: RatingCompat? = null
     open fun setMetadata(context: Context, bundle: Bundle?, ratingType: Int) {
         artwork = BundleUtils.getUri(context, bundle, "artwork")
@@ -23,7 +23,13 @@ abstract class TrackMetadata {
         album = bundle.getString("album")
         date = bundle.getString("date")
         genre = bundle.getString("genre")
-        duration = (bundle.getDouble("duration", 0.0)).toMilliseconds()
+
+        duration = if (bundle.containsKey("duration")) {
+            bundle.getDouble("duration").toMilliseconds()
+        } else {
+            null
+        }
+
         rating = BundleUtils.getRating(bundle, "rating", ratingType)
     }
 }
diff --git a/example/src/components/ActionSheet.tsx b/example/src/components/ActionSheet.tsx
@@ -20,6 +20,7 @@ const onUpdateCurrentTrackMetadata = async () => {
     await TrackPlayer.updateMetadataForTrack(currentTrackIndex, {
       title: `Random: ${randomTitle}`,
       artwork: `https://random.imagecdn.app/800/800?dummy=${Date.now()}`,
+      duration: Math.floor(Math.random()),
     });
   }
 };