Skip to content

Commit

Permalink
chore(ios): remove deprecated lowQualityZeroLatency (#2130)
Browse files Browse the repository at this point in the history
  • Loading branch information
dcvz authored Sep 21, 2023
1 parent 1333bfb commit 264ecc8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 3 additions & 0 deletions docs/docs/v4-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ instead of `null`

1. `clearMetadata()` - Instead use [`reset()`](./api/functions/player.md#reset) - which stops playback, clears the queue and clears the notification.

### General Changes
1. on iOS pitch algorithm defaults to `timeDomain` instead of `lowQualityZeroLatency`. It has been deprecated by Apple and has a few bugs on iOS 17.

### Typescript Imports

1. If you were using deep imports from RNTP, the `src` has been completely
Expand Down
6 changes: 2 additions & 4 deletions ios/RNTrackPlayer/Models/Track.swift
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,12 @@ class Track: AudioItem, TimePitching, AssetOptionsProviding {
return .varispeed
case PitchAlgorithm.music.rawValue:
return .spectral
case PitchAlgorithm.voice.rawValue:
default: // voice
return .timeDomain
default:
return .lowQualityZeroLatency
}
}

return .lowQualityZeroLatency
return .timeDomain
}

// MARK: - Authorizing Protocol
Expand Down

0 comments on commit 264ecc8

Please sign in to comment.