Provide generic bos and eos variables
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendering templates with special variables representing, e.g., BOS tokens we need to know which model the prompt is going to be passed to so as to render the template with the appropriate token. This PR adds a `model_name` attribute to the `Template` class.
rlouf
force-pushed
the
add-special-variables
branch
3 times, most recently
from
5adddb5 to
ec36ba8
Compare
We define Jinja2 `eos` and `bos` global variables that are rendered as EOS and BOS tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides generic
bosandeosvariables that can be added to a prompt template and will be rendered correctly for the specified model. For instance:This begs a question: should we automatically add BOS tokens to prompt templates? My current inclination is to answer no:
@prompt.templateshould give full control to the user over which tokens are used. We could, however, introduce a function that takes care of formatting the prompt correctly for non-chat workflows (which are handled via #4) and could handle common mistakes such as double BOS tokens.Closes #2.