Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sdist archive set to v0.0.0 #72

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix sdist archive set to v0.0.0 #72

merged 1 commit into from
Oct 10, 2024

Conversation

lapp0
Copy link
Contributor

@lapp0 lapp0 commented Oct 10, 2024

Related issue: pypa/setuptools-scm#636

Attempt to ensure sdist archive isn't saved as v0.0.0

Checking

These logs indicate sdist is now building a correct version. The release versions by tag, so the results may differ.

main sdist build logs indicating 0.0.0 used:

2024-10-10T12:59:54.3122863Z running sdist
2024-10-10T12:59:54.3124102Z running egg_info
2024-10-10T12:59:54.3139055Z creating python/outlines_core.egg-info
2024-10-10T12:59:54.3241720Z writing python/outlines_core.egg-info/PKG-INFO
2024-10-10T12:59:54.3243732Z writing dependency_links to python/outlines_core.egg-info/dependency_links.txt
2024-10-10T12:59:54.3247510Z writing requirements to python/outlines_core.egg-info/requires.txt
2024-10-10T12:59:54.3249074Z writing top-level names to python/outlines_core.egg-info/top_level.txt
2024-10-10T12:59:54.3251157Z writing manifest file 'python/outlines_core.egg-info/SOURCES.txt'
2024-10-10T12:59:54.3289533Z reading manifest file 'python/outlines_core.egg-info/SOURCES.txt'
2024-10-10T12:59:54.3291118Z adding license file 'LICENSE'
2024-10-10T12:59:54.3297893Z writing manifest file 'python/outlines_core.egg-info/SOURCES.txt'
2024-10-10T12:59:54.3299381Z running check
2024-10-10T12:59:54.3325261Z creating outlines_core-0.0.0
2024-10-10T12:59:54.3326991Z creating outlines_core-0.0.0/python
2024-10-10T12:59:54.3328231Z creating outlines_core-0.0.0/python/outlines_core
2024-10-10T12:59:54.3329599Z creating outlines_core-0.0.0/python/outlines_core.egg-info

This PRs smoke test:

2024-10-10T17:51:57.9969388Z running sdist
2024-10-10T17:51:57.9971304Z running egg_info
2024-10-10T17:51:58.0006612Z writing python/outlines_core.egg-info/PKG-INFO
2024-10-10T17:51:58.0029902Z writing dependency_links to python/outlines_core.egg-info/dependency_links.txt
2024-10-10T17:51:58.0042792Z writing requirements to python/outlines_core.egg-info/requires.txt
2024-10-10T17:51:58.0044894Z writing top-level names to python/outlines_core.egg-info/top_level.txt
2024-10-10T17:51:58.0309164Z adding license file 'LICENSE'
2024-10-10T17:51:58.0322919Z writing manifest file 'python/outlines_core.egg-info/SOURCES.txt'
2024-10-10T17:51:58.0324684Z running check
2024-10-10T17:51:58.0355472Z creating outlines_core-0.1.dev1+gd990d66

@lapp0 lapp0 marked this pull request as ready for review October 10, 2024 17:56
@rlouf rlouf merged commit ba10c61 into main Oct 10, 2024
7 checks passed
@rlouf rlouf deleted the fix-sdist-v0.0.0 branch October 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants