Remove datasets dependency
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy was only used for type checking. In addition, this information was incorrect as what was indicated as numpy ndarrays can in fact be any kind of array.
rlouf
force-pushed
the
remove-transformers-dependency
branch
from
c84942f to
c3a5ecd
Compare
The `models` module is only used for tests and benchmarking, while requiring `datasets` to be installed. We thus remove the module from the python package and move the necessary code to the test and benchmark directories directly.
rlouf
force-pushed
the
remove-transformers-dependency
branch
3 times, most recently
from
e6d405a to
46273ba
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
datasetsdependency for the python package, and themodelsmodule which was only used for testing and benchmarking. Once we agree this is the way forward I will flatten the structure of the Python package.Closes #51. Should help with #20 and #48. Supersedes #42.