Watched install targets #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
previously approved these changes
Sep 23, 2024
quernd
approved these changes
Sep 23, 2024
Try |
brandonwillard
dismissed
their stale review
The merge-base changed after approval.
brandonwillard
force-pushed
the
main
branch
from
e63edab to
c39600f
Compare
brandonwillard
requested changes
Sep 24, 2024
There was a problem hiding this comment.
cargo watch -x 'run-script install'seems to loop indefinitely on my machine (i.e.pip install ...-ing over and over).Try
cargo watch -w src -x 'run-script install'to only watch thesrcdirectory. It might be watching build directories.
If that's the case, let's add it to the Makefile. N.B. Seems like it should also be watching Cargo.toml.
brandonwillard
force-pushed
the
auto-install-target
branch
from
92a8410 to
57dc5e5
Compare
umut-sahin
force-pushed
the
auto-install-target
branch
from
c7d552d to
e51c58b
Compare
umut-sahin
force-pushed
the
auto-install-target
branch
from
e51c58b to
012cef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #31)
It also introduces optimized versions of install targets.