Optimize output of non-required properties #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this schema:
We currently produce the following regex (simplified, and line-broken)
This works perfectly well, but contains redundancy. This is seen by the
fact that all three alternatives would match JSON with all three fields.
The different alternatives currently model which field is mandatory.
I propose that we make the alternatives model the choice of last field.
This will produce a regex like this:
This will give us a shorter, but 100% equivalent regex.
Both of the test cases I've changed have been run through this regex equivalence tester