-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email format in JSON schema #128
Conversation
@sky-2002 Yes, it's correct now! We just need to resolve conflicts with main |
55b3e4f
to
3275dd5
Compare
@torymur sorry for the messy commits, had to force push due to some unwanted |
I could not find a perfect regex, and had to remove some tests like Update: I checked the email regex from |
One thing I forgot to ask you in the previous PR too, could you please add
|
This reverts commit 283f63c.
Adds URI parsing code and tests Refer dottxt-ai#127
Adds URI parsing code and tests Refer dottxt-ai#127
2461618
to
0c955c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this @sky-2002 🌟 Appreciate your effort!
To speed up the process I will merge this right now and do a tiny follow up to expose these new types to python.
@torymur cool, I will add those in a separate PR right away, thanks a lot for quick reviews |
I have added a basic email parsing regex, refer #107 .
Lmk if a more complex regex (compliant with some RFC) is needed.
Closes #107.