Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

Add HWPF .NET Core support to read Word / Excel 2003 ( .doc / .xls) forma #91

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RockNHawk
Copy link

Add HWPF .NET Core support to read Word / Excel 2003 ( .doc / .xls) format

Fix HWPF multi-thread bug : System.InvalidOperationException: Collection was modified; enumeration operation may not execute.

h and others added 10 commits September 8, 2018 20:00
.NET Core support readme
add
[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("TestCases,PublicKey=002400000480000094000000060200000024000052534131000400000100010095ccd95af3b39d8bc20544d3f47fd24b53ebc5ccb693eaed116290629f8cd882c827ebd511ad59449224f0718d3f9d03b64945a6c8b6644266001b8c8426185330e3d96da70ae16d4acc21b8d4d480f1385c7e924273179375aa88f81380a72fb115712a313379d16aed4aa36208ee3b4a5dd785b06a07b2d868e3227f4495b5")]
…ation operation may not execute.

       at System.Collections.Generic.List`1.Enumerator.MoveNextRare()
       at System.Collections.Generic.List`1.Enumerator.MoveNext()
       at NPOI.HWPF.Model.CHPBinTable.Rebuild(ComplexFileTable complexFileTable) in /Users/Private/git/tianzen-third lib/NPOI-netcore/scratchpad/HWPF/Model/CHPBinTable.cs:line 287
       at NPOI.HWPF.HWPFDocument..ctor(DirectoryNode directory) in /Users/Private/git/tianzen-third lib/NPOI-netcore/scratchpad/HWPF/HWPFDocument.cs:line 267
       at NPOI.HWPF.HWPFDocument..ctor(POIFSFileSystem pfilesystem) in /Users/Private/git/tianzen-third lib/NPOI-netcore/scratchpad/HWPF/HWPFDocument.cs:line 154
       at NPOI.HWPF.HWPFDocument..ctor(Stream istream) in /Users/Private/git/tianzen-third lib/NPOI-netcore/scratchpad/HWPF/HWPFDocument.cs:line 141
       at Toxy.Parsers.Word2003TextParser.Parse() in G:\code\toxy\ToxyFramework\Parsers\Word2003TextParser.cs:line 23
### NPOI
### .NET Core support

Add HWPF .NET Core support to read .doc Word 2003 format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add the descption to README, it will be add to the PR desciption section

<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>NPOI.HWPF</RootNamespace>
<AssemblyName>NPOI.ScratchPad.HWPF</AssemblyName>
<TargetFramework>netcoreapp2.1</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need both support .net framework 4.6.1 and .net standard 2.0 , not the netcoreapp

@@ -0,0 +1,296 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to keep .csproj file clear

@yang-xiaodong
Copy link
Member

Hello , thanks your PR~

Are you missing some unit test about HWPF support, and all passed ?

In addition, we need to both support the .net standard 2.0 and .net framework 4.6.1, because someone are stills using .net framework now , can you do it ?

@RockNHawk
Copy link
Author

Hello , thanks your PR~

Are you missing some unit test about HWPF support, and all passed ?

In addition, we need to both support the .net standard 2.0 and .net framework 4.6.1, because someone are stills using .net framework now , can you do it ?

I'm sorry about I forget the .NET Framework version... recently I have no such time to do this work, I will add the .NET Framework and unit test in the feature.

I have tested HWPF in my application it's work well (except .ppt), so I just pull it if someone needs use NPOI in .NET Core to read Office 2003 can use it or find it and compile it by self.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants