Use pattern matching in arrow test utils to improve readability #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhsteve
reviewed
Oct 9, 2020
src/csharp/Microsoft.Spark.UnitTest/TestUtils/ArrowTestUtils.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.UnitTest/TestUtils/ArrowTestUtils.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.UnitTest/TestUtils/ArrowTestUtils.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.UnitTest/TestUtils/ArrowTestUtils.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.UnitTest/TestUtils/ArrowTestUtils.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.UnitTest/TestUtils/ArrowTestUtils.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Oct 9, 2020
Co-authored-by: Steve Suh <[email protected]>
Co-authored-by: Steve Suh <[email protected]>
|
@suhsteve Changes done, Can you review again.? |
|
@suhsteve Changes done, Can you review again.? |
suhsteve
approved these changes
Oct 12, 2020
|
@suhsteve when this will be merged? any release cycle? |
|
@SARAVANA1501 Thanks for your patience. We have been busy with releasing 1.0, and we will get back to PRs soon. |
|
LGTM. Thanks @SARAVANA1501 ! |
imback82
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the readability using c# pattern matching
#25