Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create custom instances of TestAssetsManager in tests, use SdkTest base instead #45071

Open
wants to merge 2 commits into
base: release/9.0.2xx
Choose a base branch
from

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 23, 2024

No description provided.

@tmat tmat requested a review from a team as a code owner November 23, 2024 16:51
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 23, 2024
@tmat
Copy link
Member Author

tmat commented Nov 23, 2024

@dsplaisted @marcpopMSFT ptal

Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I like to see the tests becoming more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants