Support ExperimentalAttribute.Message #76060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
AlekseyTs
removed
the
untriaged
jcouv
reviewed
Nov 25, 2024
| @@ -29,6 +29,8 @@ public sealed class ExperimentalAttribute : Attribute | |||
| public ExperimentalAttribute(string diagnosticId) { } | |||
|
|
|||
| public string? UrlFormat { get; set; } | |||
|
|
|||
| public string? Message { get; set; } | |||
There was a problem hiding this comment.
How should we track the update to the spec?
One option would be to move that doc to roslyn/docs/features and update it there, as this is more a compiler feature than a language feature (we enforce regardless of language version) anyways.
There was a problem hiding this comment.
I can update the spec in place. I see no value in moving the document around for the API change.
|
@jcouv, @dotnet/roslyn-compiler Please review |
jcouv
reviewed
Nov 25, 2024
src/Compilers/CSharp/Portable/Symbols/ObsoleteAttributeHelpers.cs
Outdated
Show resolved
Hide resolved
|
@dotnet/roslyn-compiler For the second review. |
jjonescz
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75221