-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft.Extensions.Configuration provider for azure queue streaming #8929
base: main
Are you sure you want to change the base?
Conversation
{ | ||
public void Configure(ISiloBuilder builder, string name, IConfigurationSection configurationSection) | ||
{ | ||
builder.AddAzureQueueStreams(name, (OptionsBuilder<AzureQueueOptions> optionsBuilder) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if this also needs to support configuring the MessageVisibilityTimeout
. I can get that added in if so.
@benjaminpetit PTAL - what should IConfiguration support look like for Azure Queues @tskimmett a test would be helpful here. Eg, update some/all of the existing Azure Queue Streaming tests to use this functionality. |
I looked to see if there were relevant tests that could be updated for this and couldn't really tell, but I can take another look at that. |
I've updated |
As a side note, I ran into some trouble running tests to begin with for a few reasons:
If you'd like, I can open a PR for that last point to slightly improve the dev experience on non-windows platforms, but not sure if you're too concerned about that. |
dcafdc5
to
45fde99
Compare
@ReubenBond @benjaminpetit Let me know if you have any more suggestions or feel more tests are necessary. |
I think it's a good start, but it should also be possible to configure For tests, I think it would be better to have simple unit tests that just test the config parsing (I believe there is property to get the |
Sorry it's been so long, life got in the way, but I am determined to help improve the Aspire integration (albeit selfishly 🙂). Please let me know what else needs to be done to get this over the finish line. |
@benjaminpetit Any chance you can take another look? |
a4041e2
to
33acad1
Compare
I'm interested in using Aspire with an Orleans project I'm working on which uses Azure storage for persistence/streaming, but I saw Orleans doesn't yet support the streaming config sent over by the Aspire apphost. I based my changes off of #8764 and did some pretty minimal manual testing using the orleans sample in the Aspire playground.
Microsoft Reviewers: Open in CodeFlow