test(serializer): add failing test for record serializer when in external proj and using GenerateCodeForDeclaringAssembly
#8860
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlautier
changed the title
stephenlautier
changed the title
GenerateCodeForDeclaringAssembly
|
Could you grant me access to push to your PR branch? Docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
…e/serialize-record-external-ctor-excluded
|
Sorry for the late reply, just seeing this now. Unfortunately im not able to see the option from the doc, maybe its cause forked on the Org sketch7 and not personal? Non the less I sent you invite for write permissions on Sketch7/orleans, if thats good for you |
|
also updated PR + merged conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per doc https://learn.microsoft.com/en-us/dotnet/orleans/host/configuration-guide/serialization?pivots=orleans-7-0#serializing-record-types
The following is not working when using
GenerateCodeForDeclaringAssemblyfor an external lib (and Sdk is not added to the library)Just added a failing test (which is skipped) with a repro
Microsoft Reviewers: Open in CodeFlow