Fix for DatePicker displays incorrect date selection when navigating to next month. #26064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in CreatePlatformView.
|
Hey there @BagavathiPerumal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The issue was caused by incorrect handling of the month parameter when creating the DatePickerDialog. The month value from VirtualView?.Date was passed directly to the CreateDatePickerDialog method without adjusting for the difference in month indexing between the .NET framework (1-based) and Android's DatePickerDialog (0-based). This mismatch resulted in an incorrect month being displayed when navigating between months in the dialog.
Description of Issue Fix
The fix involves adjusting the month value passed to the DatePickerDialog in the CreatePlatformView method by subtracting 1 from the DateTime.Month value. This ensures compatibility with Android's 0-based month indexing, while maintaining correct behavior with the .NET framework’s 1-based month indexing, allowing the date to display correctly when navigating between months.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #25943
Output
DatePicker-BeforeFix.mp4
DatePicker-AfterFix.mp4