Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenAI] SFT Example #7316

Merged
merged 9 commits into from
Nov 25, 2024
Merged

[GenAI] SFT Example #7316

merged 9 commits into from
Nov 25, 2024

Conversation

LittleLittleCloud
Copy link
Contributor

@LittleLittleCloud LittleLittleCloud commented Nov 18, 2024

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

This PR adds the necessary bits for supervised fine-tuing LLM #7325 , which is also pre-requisite of #7287 and #7288

@LittleLittleCloud LittleLittleCloud changed the title [GenAI] SFT Sample [GenAI] SFT Example Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 54.95050% with 91 lines in your changes missing coverage. Please review.

Project coverage is 68.88%. Comparing base (5090327) to head (29ce1b9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ore/Trainer/CasualLMSupervisedFineTuningTrainer.cs 0.00% 52 Missing ⚠️
src/Microsoft.ML.GenAI.LLaMA/LlamaForCausalLM.cs 0.00% 13 Missing ⚠️
...Microsoft.ML.GenAI.Core/Trainer/CausalLMDataset.cs 80.95% 9 Missing and 3 partials ⚠️
...soft.ML.GenAI.Core/Pipeline/CausalLMModelOutput.cs 0.00% 4 Missing ⚠️
src/Microsoft.ML.GenAI.LLaMA/Module/LlamaModel.cs 0.00% 4 Missing ⚠️
...osoft.ML.GenAI.Phi/Phi3/Phi3ChatTemplateBuilder.cs 0.00% 4 Missing ⚠️
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7316      +/-   ##
==========================================
+ Coverage   68.87%   68.88%   +0.01%     
==========================================
  Files        1470     1473       +3     
  Lines      274005   274202     +197     
  Branches    28403    28418      +15     
==========================================
+ Hits       188717   188883     +166     
- Misses      77970    77999      +29     
- Partials     7318     7320       +2     
Flag Coverage Δ
Debug 68.88% <54.95%> (+0.01%) ⬆️
production 63.29% <38.92%> (+0.01%) ⬆️
test 89.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...osoft.ML.GenAI.Core/Pipeline/CausalLMModelInput.cs 96.77% <100.00%> (+96.77%) ⬆️
...soft.ML.GenAI.LLaMA/Llama3_1ChatTemplateBuilder.cs 70.00% <100.00%> (+1.16%) ⬆️
...crosoft.ML.GenAI.Core.Tests/CasualLMDatasetTest.cs 100.00% <100.00%> (ø)
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs 0.00% <0.00%> (ø)
...soft.ML.GenAI.Core/Pipeline/CausalLMModelOutput.cs 0.00% <0.00%> (ø)
src/Microsoft.ML.GenAI.LLaMA/Module/LlamaModel.cs 17.82% <0.00%> (-0.74%) ⬇️
...osoft.ML.GenAI.Phi/Phi3/Phi3ChatTemplateBuilder.cs 42.10% <0.00%> (-1.74%) ⬇️
...Microsoft.ML.GenAI.Core/Trainer/CausalLMDataset.cs 80.95% <80.95%> (ø)
src/Microsoft.ML.GenAI.LLaMA/LlamaForCausalLM.cs 15.30% <0.00%> (-2.35%) ⬇️
...ore/Trainer/CasualLMSupervisedFineTuningTrainer.cs 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

@LittleLittleCloud LittleLittleCloud marked this pull request as ready for review November 22, 2024 18:37
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @LittleLittleCloud.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants