-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VMs #7087
Update VMs #7087
Conversation
@michaelgsharp was already doing this in #7034. I think we require more changes than just retargeting because of differences in test output. I'll defer to @michaelgsharp's call though. |
I see, we were not changing the build machines in that other PR - only helix queues. |
I think it should be just fine. There are some fixes I need to do to update the Windows queues, but this doesn't change those so that won't hit it. We also build our official bits for Linux on CentOS machines, so this shouldn't have any problems/issues in that area either. |
I also filed this issue: #7088 I commented on the other PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7087 +/- ##
==========================================
- Coverage 68.82% 68.47% -0.35%
==========================================
Files 1255 1262 +7
Lines 250358 254263 +3905
Branches 25550 26236 +686
==========================================
+ Hits 172310 174113 +1803
- Misses 71438 73470 +2032
- Partials 6610 6680 +70
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks like the issue is on the Windows leg so I'll let you folks look at that. |
BuildAnalysis linked the failure to #7067 which is a known issue in auto-ml tests. Merging. |
We are deprecating
Ubuntu.1804.Amd64.Open
.