Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VMs #7087

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Update VMs #7087

merged 2 commits into from
Mar 21, 2024

Conversation

richlander
Copy link
Member

We are deprecating Ubuntu.1804.Amd64.Open.

@ericstj
Copy link
Member

ericstj commented Mar 20, 2024

@michaelgsharp was already doing this in #7034. I think we require more changes than just retargeting because of differences in test output. I'll defer to @michaelgsharp's call though.

@ericstj
Copy link
Member

ericstj commented Mar 20, 2024

I see, we were not changing the build machines in that other PR - only helix queues.

@michaelgsharp
Copy link
Member

I think it should be just fine. There are some fixes I need to do to update the Windows queues, but this doesn't change those so that won't hit it. We also build our official bits for Linux on CentOS machines, so this shouldn't have any problems/issues in that area either.

@richlander
Copy link
Member Author

I also filed this issue: #7088

I commented on the other PR.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.47%. Comparing base (8b483f4) to head (efec8e6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7087      +/-   ##
==========================================
- Coverage   68.82%   68.47%   -0.35%     
==========================================
  Files        1255     1262       +7     
  Lines      250358   254263    +3905     
  Branches    25550    26236     +686     
==========================================
+ Hits       172310   174113    +1803     
- Misses      71438    73470    +2032     
- Partials     6610     6680      +70     
Flag Coverage Δ
Debug 68.47% <ø> (-0.35%) ⬇️
production 62.87% <ø> (-0.39%) ⬇️
test 88.56% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

@richlander
Copy link
Member Author

Looks like the issue is on the Windows leg so I'll let you folks look at that.

@ericstj
Copy link
Member

ericstj commented Mar 21, 2024

BuildAnalysis linked the failure to #7067 which is a known issue in auto-ml tests. Merging.

@ericstj ericstj merged commit d507a1e into dotnet:main Mar 21, 2024
22 of 25 checks passed
@richlander richlander deleted the eol- branch March 21, 2024 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants