Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AI Evaluation tests for eShopSupport. #49

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

peterwald
Copy link
Member

Add EvaluationTests project that demonstrates how to use Microsoft.Extensions.AI.Evaluation to run evaluations on LLM prompts and responses.

Testing updates and cleanup.

Latest updates

Update library

Update evaluations.

Add JSON cleanup

Add different kinds of evaluation tests, defer to a eval handler

Fix writing of scenario results

Update to latest Evaluation library API

Update Evaluation API

Simplify the API

Update packages to public feed

Add required data dep to Tokenizers

Add check for diagnostic errors

Revert changes to run against AzureOpenAI

More fixes

Fix using
@shyamnamboodiripad
Copy link

@peterwald Should we add a README.md file under the test/EvaluationTests folder that contains instructions for running the tests / viewing the report?

@shyamnamboodiripad
Copy link

shyamnamboodiripad commented Nov 19, 2024

@luisquintanilla @peterwald should we also remove the src\Evaluator project now that we have EvaluationTests? This could be something to look into later on (post merge) as this could help to make the guidance on how to run evaluations less ambiguous overall.

I am guessing we don't want to do this yet since not all tests from the src\Evaluator have been ported over yet?

test/EvaluationTests/AnswerScoringEvaluator.cs Outdated Show resolved Hide resolved
test/EvaluationTests/EvaluationTests.csproj Outdated Show resolved Hide resolved
test/EvaluationTests/EvaluationTests.cs Outdated Show resolved Hide resolved
@luisquintanilla
Copy link
Contributor

@luisquintanilla @peterwald should we also remove the src\Evaluator project now that we have EvaluationTests? This could be something to look into later on (post merge) as this could help to make the guidance on how to run evaluations less ambiguous overall.

I am guessing we don't want to do this yet since not all tests from the src\Evaluator have been ported over yet?

Since we're recommending using the evaluations in the test directory, I think it's fine to remove it.

@peterwald
Copy link
Member Author

@luisquintanilla @peterwald should we also remove the src\Evaluator project now that we have EvaluationTests? This could be something to look into later on (post merge) as this could help to make the guidance on how to run evaluations less ambiguous overall.
I am guessing we don't want to do this yet since not all tests from the src\Evaluator have been ported over yet?

Since we're recommending using the evaluations in the test directory, I think it's fine to remove it.

There is more in the Evaluator project than what is done by the tests. I'll leave it here for now to not eliminate those options.

@shyamnamboodiripad
Copy link

@luisquintanilla @peterwald should we also remove the src\Evaluator project now that we have EvaluationTests? This could be something to look into later on (post merge) as this could help to make the guidance on how to run evaluations less ambiguous overall.
I am guessing we don't want to do this yet since not all tests from the src\Evaluator have been ported over yet?

Since we're recommending using the evaluations in the test directory, I think it's fine to remove it.

There is more in the Evaluator project than what is done by the tests. I'll leave it here for now to not eliminate those options.

Sounds good - should we log an issue to port over the remaining functionality and remove this eventually? @luisquintanilla

@luisquintanilla
Copy link
Contributor

luisquintanilla commented Nov 25, 2024

Sounds good - should we log an issue to port over the remaining functionality and remove this eventually? @luisquintanilla

Yeah. That would be great.

Tracking here #50. Feel free to update / add details as needed.

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @peterwald @shyamnamboodiripad

One last question before merging. Is this using the latest version of the libraries? If not, can you bump the version and then I'll merge.

Thanks

@luisquintanilla luisquintanilla merged commit 690d081 into dotnet:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants