Update to Aspire 9 #43

DamianEdwards · 2024-10-11T23:50:59Z

This updates Aspire to the upcoming 9.0-rc.1 release and retargets the projects to net9.0.

It also moves the Python inference app into a container so that Python doesn't need to be installed on the host machine when developing. The container bind-mounts the python app files and enables Uvicorn reloading when running in dev.

- Make the PythonInference app use a venv - Remove the custom resource & use AddPythonApp - Update .gitignore so .venv dir is ignored

…date

eerhardt · 2024-10-12T20:05:16Z

Directory.Packages.props

+    <PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.AppHost.SDK" Version="$(AspireVersion)" />
+    <PackageVersion Include="Aspire.Hosting.AppHost" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Hosting.Azure.AppContainers" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Hosting.Azure.Storage" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Hosting.PostgreSQL" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Hosting.Python" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Hosting.Qdrant" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Hosting.Redis" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Hosting.Testing" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.Npgsql.EntityFrameworkCore.PostgreSQL" Version="9.0.0-rc.1.24511.1" />
+    <PackageVersion Include="Aspire.StackExchange.Redis" Version="9.0.0-rc.1.24511.1" />


These versions aren't in sync. It would be nice to keep using the common AspireVersion property.

Suggested change

<PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.AppHost.SDK" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.AppHost" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Hosting.Azure.AppContainers" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Hosting.Azure.Storage" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Hosting.PostgreSQL" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Hosting.Python" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Hosting.Qdrant" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Hosting.Redis" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Hosting.Testing" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Npgsql.EntityFrameworkCore.PostgreSQL" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.StackExchange.Redis" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.AppHost.SDK" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.AppHost" Version="$(AspireVersion) />

<PackageVersion Include="Aspire.Hosting.Azure.AppContainers" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.Azure.Storage" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.PostgreSQL" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.Python" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.Qdrant" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.Redis" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Hosting.Testing" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.Npgsql.EntityFrameworkCore.PostgreSQL" Version="$(AspireVersion)" />

<PackageVersion Include="Aspire.StackExchange.Redis" Version="$(AspireVersion)" />

eerhardt · 2024-10-12T20:05:35Z

Directory.Packages.props

-    <PackageVersion Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
-    <PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="$(AspireVersion)" />
+    <PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.0-rc.2.24473.5" />
+    <PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="9.0.0-rc.1.24511.1" />


Suggested change

<PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="9.0.0-rc.1.24511.1" />

<PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="$(AspireVersion)" />

eerhardt · 2024-10-12T20:05:58Z

src/AppHost/AppHost.csproj

@@ -1,27 +1,25 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
+  <Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0-rc.1.24511.1" />


Suggested change

<Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0-rc.1.24511.1" />

<Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0-rc.1.24509.13" />

src/DataIngestor/DataIngestor.csproj

SteveSandersonMS · 2024-10-14T08:39:04Z

nuget.config

 <configuration>
  <packageSources>
    <!--To inherit the global NuGet package sources remove the <clear/> line below -->
    <clear />
    <add key="nuget" value="https://api.nuget.org/v3/index.json" />
+    <add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />


Is this for the Aspire 9.x prerelease packages?

Yes. These will hit public nuget.org tomorrow.

SteveSandersonMS · 2024-10-14T09:02:02Z

test/E2ETest/Infrastructure/AppHostFixture.cs

@@ -21,7 +22,7 @@ private async Task<DistributedApplication> InitializeAsync()
        Environment.CurrentDirectory = Projects.AppHost.ProjectPath;
        Environment.SetEnvironmentVariable("E2E_TEST", "true");
        Environment.SetEnvironmentVariable("E2E_TEST_CHAT_COMPLETION_CACHE_DIR",
-            Path.Combine(Projects.E2ETest.ProjectPath, "ChatCompletionCache"));
+            Path.Combine(Projects.AppHost.ProjectPath, "ChatCompletionCache"));


Out of interest, why change this?

Also if you do change this, I think you'd need to regenerate the cache or at least move all its files to the new directory, since they are meant to be stored in source control.

Good catch, I think I changed this as a test and forgot to change it back. For a moment at least the E2ETest project no longer showed up as a member of Projects.

@SteveSandersonMS Actually, I take it back...this still is an issue. E2ETest is no longer in the Projects namespace nor is there any metadata created for it. I'm not sure how this code originally worked, before the update. Is there a better way to get the project path now?

SteveSandersonMS · 2024-10-14T13:28:04Z

It also moves the Python inference app into a container

I think this is absolutely great and we definitely should do it.

However I also think we shouldn't consider this to be a complete solution for #42. Since getting this branch, I've been trying for about 30 mins to make the app run but haven't yet got the Python container to build properly. It took over 10 mins to download the Python dependencies then stopped for a long time saying exporting to image. Eventually it continued but seems to have failed with this at the end of the Docker log:

2024-10-14T14:23:01 #9 DONE 45.0s
2024-10-14T14:23:01 
2024-10-14T14:23:01 View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/vwqseg2b22idn618phjplc0xm
2024-10-14T14:23:03 
2024-10-14T14:23:03 Error response from daemon: No such image: sha256:b40b44cfaec46ee67768396149dc00c5df75c3ddf76e7f57ab3759b2cb38a109
2024-10-14T14:23:07 Error response from daemon: No such image: sha256:b40b44cfaec46ee67768396149dc00c5df75c3ddf76e7f57ab3759b2cb38a109
2024-10-14T14:23:12 Error response from daemon: No such image: sha256:b40b44cfaec46ee67768396149dc00c5df75c3ddf76e7f57ab3759b2cb38a109

I don't know what's going on with that, and will next try clearing out the Docker image it built and try starting it again. This is not to criticise anything in the implementation, which looks entirely correct, but just to acknowledge that even with this automation it remains prone to be a sticking point for new users.

So although I definitely think it's better to run this in Docker than not do, it's probably better still if we also make the Python dependency optional (defaulting to not used).

Update: After restarting, it did successfully complete building the Docker container and runs the Python code.

src/AppHost/Program.cs

SteveSandersonMS · 2024-10-14T14:59:46Z

src/AppHost/Program.cs

+var pythonInference = builder.AddDockerfile("python-inference", "../PythonInference", /* default dockerfile */ null, stage)
+    .WithHttpEndpoint(targetPort: 62394, env: "UVICORN_PORT")
+    .WithContainerRuntimeArgs("--gpus=all")
+    .WithLifetime(ContainerLifetime.Persistent);


Does this definitely work? It does cause the Docker container to keep running even after AppHost is shut down (albeit removing the port mapping, which is a bit inconvenient).

But then each time I start the AppHost project using Ctrl+F5, it kills the previous Docker container and starts a new one, which seems to defeat the purpose of the feature.

Does this definitely work? It does cause the Docker container to keep running even after AppHost is shut down (albeit removing the port mapping, which is a bit inconvenient).

If you want stable ports inside and outside of Aspire for this resource you can pass the desired port numbers and disable the proxying on the endpoint.

But then each time I start the AppHost project using Ctrl+F5, it kills the previous Docker container and starts a new one, which seems to defeat the purpose of the feature.

Definitely shouldn't be doing that and I wasn't seeing that locally. It will only do that if it detects changes to the container definition but I'm not sure of the exact variables it includes. @danegsta?

By default we consider the container image name (or image sha in the case of building via dockerfile), ports, volume mounts, environment, and the command/arguments used to launch the container.

The port mapping shouldn't be lost for a persistent container, but it generally won't show up in the Docker Desktop UI due to a seeming bug in how they report randomly assigned host ports (which we use). You have to inspect the container and look in the networking config section to see the real port, otherwise it just shows up as 0 in the other inspected port data and is missing from the UI.

jmatthiesen and others added 9 commits October 9, 2024 22:58

Starting the migration to .NET 9 and .NET Aspire 9

0167d6f

Fix up package versions and feeds

09cf576

Remove unused property

284d5a4

Use Aspire.Hosting.Python for inference app

8bd24c4

- Make the PythonInference app use a venv - Remove the custom resource & use AddPythonApp - Update .gitignore so .venv dir is ignored

Change the PythonInference app to run in a container via a Dockerfile

e1bf350

Update to latest Aspire & improve Python dockerfile

4b64acf

Merge branch 'damianedwards/python-tweaks' into jmatthiesen/aspire9up…

ed7a0ea

…date

Merge branch 'main' into jmatthiesen/aspire9update

93ef5a2

Tweaks

79e3be1

DamianEdwards requested review from SteveSandersonMS and eerhardt October 11, 2024 23:50

eerhardt reviewed Oct 12, 2024

View reviewed changes

src/DataIngestor/DataIngestor.csproj Outdated Show resolved Hide resolved

SteveSandersonMS reviewed Oct 14, 2024

View reviewed changes

Simplify DataIngestor.csproj

cb6646d

SteveSandersonMS reviewed Oct 14, 2024

View reviewed changes

src/AppHost/Program.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed Oct 14, 2024

View reviewed changes

Update src/AppHost/Program.cs

4ead7ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Aspire 9 #43

Update to Aspire 9 #43

DamianEdwards commented Oct 11, 2024

eerhardt Oct 12, 2024

eerhardt Oct 12, 2024

eerhardt Oct 12, 2024

SteveSandersonMS Oct 14, 2024

DamianEdwards Oct 14, 2024

SteveSandersonMS Oct 14, 2024

SteveSandersonMS Oct 14, 2024

jmatthiesen Oct 14, 2024

jmatthiesen Oct 14, 2024

SteveSandersonMS commented Oct 14, 2024 •

edited

Loading

SteveSandersonMS Oct 14, 2024 •

edited

Loading

DamianEdwards Oct 14, 2024

danegsta Oct 14, 2024 •

edited

Loading

	<PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="9.0.0-rc.1.24511.1" />
	<PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="$(AspireVersion)" />

		@@ -1,27 +1,25 @@
		<Project Sdk="Microsoft.NET.Sdk">

		<Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0-rc.1.24511.1" />

Update to Aspire 9 #43

Are you sure you want to change the base?

Update to Aspire 9 #43

Conversation

DamianEdwards commented Oct 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SteveSandersonMS commented Oct 14, 2024 • edited Loading

SteveSandersonMS Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danegsta Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

SteveSandersonMS commented Oct 14, 2024 •

edited

Loading

SteveSandersonMS Oct 14, 2024 •

edited

Loading

danegsta Oct 14, 2024 •

edited

Loading