This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Added optional/default parameters for StreamWriter/StreamReader #24056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CoreFX side: dotnet/corefx#36959 |
|
Could you please disable the outdated CoreFX test in https://github.com/dotnet/coreclr/blob/master/tests/CoreFX/CoreFX.issues.json to make the PR green |
justinvp
reviewed
Apr 17, 2019
|
According to failing builds, it looks like System.Text.Encoding is not nullable anymore: Is it intended? Should I change the constructor to nullable "Encoding?" |
stephentoub
approved these changes
Apr 23, 2019
|
Thanks. @JeremyKuhne, can you please review as well? |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…et/coreclr#24056) * Added optional/default parameters for StreamWriter/StreamReader * Disabled outdated test * Changed default encoding to UTF8NoBOM * Made encoding parameter nullable Commit migrated from dotnet/coreclr@57a40b9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the CoreCLR side of dotnet/corefx#8173