Use the latest available jdk #59788
Use the latest available jdk #59788
Conversation
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
@wtgodbe @BrennanConroy this will fix your builds (everything is broken right now). I opened dotnet/source-build#4816 to track how to best handle this going forward, including your local script to install a jdk. We patched the VMR with this change to unblock builds. |
ViktorHofer
requested review from
BrennanConroy,
halter73,
wtgodbe and
a team
as code owners
Whoa, github AI automatically populated an accurate commit description for my commit. Neat |
| @@ -22,7 +22,7 @@ allprojects { | |||
| version project.findProperty('packageVersion') ?: "99.99.99-dev" | |||
|
|
|||
| java { | |||
| sourceCompatibility = 1.8 | |||
| sourceCompatibility = 1.9 | |||
There was a problem hiding this comment.
Why was this changed?
invalid source release: 9
There was a problem hiding this comment.
See dotnet/sdk#45822 (comment)
We started hitting an error w/ version 8 when updating to 11.0.25:
EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]
I'm not sure how to proceed if the underlying machines are in a mixed state, as they seem to be (some have 11.0.24, which is incompatible w/ 9, and some have 11.0.25, which is incompatible w/ 8)
There was a problem hiding this comment.
Oh, never mind, it's Helix, not the build machines. Do you know why non-windows is on JDK 10 & windows is on 11 here? The Helix failure was only on Mac.
aspnetcore/eng/targets/Helix.targets
Lines 3 to 4 in e0e0224
There was a problem hiding this comment.
I thought all machines were supposed to have moved to 21.X?
There was a problem hiding this comment.
Probably should remove those lines now? Wonder if we used to have to install the jdk ourselves 5 years ago.
There was a problem hiding this comment.
Oh, I totally missed that. So it looks like whatever version of macos-openjdk is pre-installed on the MacOS-13 queue isn't compatible w/ 1.9. @dotnet/dnceng does anyone know how we can check what version is installed on OSX.13.amd64.open? helix.dot.net doesn't list one.
There was a problem hiding this comment.
all macOS machines will have OpenJDK 8 and 21 after they are next refreshed
So maybe the machines haven't been refreshed?
There was a problem hiding this comment.
Now we have
ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
On Windows 🙄
I think dnceng rolled back the machine updates, we might have to hold this until all machines have a JDK that supports 1.9 |
They rolled back yes, but the 1.9 sourceCompatibility setting works fine in the VMR with this patch. Are you sure that the current jdk that is installed on CI images don't support |
|
@ViktorHofer check the failed jobs. I think it works in the VMR because we're using AzureLinux 3.0 which likely comes with a new JDK, but the builds here are on Ubuntu 20.04 and according to helix.dot.net it only has openjdk-8-jdk again after the rollback. |
|
Got it. Then I guess we just park this PR until the images get updated again and keep the patch in the VMR meanwhile. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
See dotnet/source-build#4816