Release 5.14.0 #548

mclift · 2023-11-08T16:48:04Z

As suggested by @HenningNT, this PR is for release 5.14.0.

…package from forks.

…ecommendations

Enable Source Link and Determnistic Builds; don't attempt to publish package from forks.

Enable Source Link & Deterministic Builds

Create SECURITY.md

Add guide to contributing

…ync version. Fix bug where trigger information is missing from the StateMachine.GetInfo.

… only initialised by a call to AddRelationships. However, for StateMachineInfo.InitialState, this never happens. Therefore StateMachineInfo.InitialState.Transitions throws a System.ArgumentNullException. The StateInfo object should not throw if "half initialised"

…State.Transitions-throws StateMachineInfo.InitialState.Transitions throws if AddRelationships not called

Fix spelling mistake "fireing" to "firing"

…-trigger-information Trigger information is missing for OnEntryFromAsync

…tion mandatory

…rywhere within StateMachine

…-async-if fix: InternalTransitionAsyncIf guard parameters

Implemented an example for an alarm

Remove obsolete TargetFrameworks

…erationException Bugfix: execute OnEntryFromAsync actions from FireAsync

…tion-async-if fix: InternalTransitionAsyncIf guard parameters (update)

This is async counterpart to existing Fire(TriggerWithParameters, params object[]) method. Required for firing triggers with more than 3 parameters asynchronously.

…a substate, if the machine is already in that substate then the entry action shouldn't trigger again

docs: Update README.md dead link for simplestatemachine

In the case of a superstate having a trigger that moves the state to …

crozone · 2023-11-13T02:11:03Z

Test failure, going to take a look:

Stateless.Tests.SynchronizationContextFixture.Multiple_OnEntry_on_Reentry_should_retain_SyncContext [FAIL]
Failed Stateless.Tests.SynchronizationContextFixture.Multiple_OnEntry_on_Reentry_should_retain_SyncContext [47 ms]
Error Message:
Assert.NotEqual() Failure
Expected: Not MaxConcurrencySyncContext { }
Actual: MaxConcurrencySyncContext { }

Added FireAsync(TriggerWithParameters, params object[]) overload

mclift · 2023-11-13T15:00:02Z

Thanks, @crozone. Seems like that test is a little flaky: https://github.com/dotnet-state-machine/stateless/actions/runs/6746401636/job/18445672212#step:5:31

HenningNT

I approve, but didn't check anything :-D

HenningNT · 2023-11-13T15:46:57Z

Might I suggest releasing as soon as possible after a useful change has been merged?

crozone · 2023-11-14T01:13:11Z

@mclift It looks like the issue is in the testing harness itself that tries to lose the sync context. There was an attempt to fix this here:

https://github.com/dotnet-state-machine/stateless/pull/528/files

But it looks like there still may be an issue with this strategy.

So Stateless isn't responsible for the failing test but the actual testing code. I think it's safe to proceed.

mclift · 2023-11-14T07:18:10Z

Thanks for checking that out, @crozone!

mclift and others added 30 commits December 30, 2022 18:26

Enable Source Link and Determnistic Builds; don't attempt to publish …

2fed1cf

…package from forks.

Merge branch 'dotnet-state-machine:dev' into feature/net-foundation-r…

aff2f73

…ecommendations

Merge pull request #3 from mclift/feature/net-foundation-recommendations

ec93a7c

Enable Source Link and Determnistic Builds; don't attempt to publish package from forks.

Remove unsupported input.

a436129

Create SECURITY.md

0883481

Create CONTRIBUTING.md

159b88f

Link to CONTRIBUTING.md in README.

cbdeef9

Merge pull request #501 from mclift/dev

3a0d1fe

Enable Source Link & Deterministic Builds

Merge pull request #502 from dotnet-state-machine/docs/security-policy

03e9752

Create SECURITY.md

Merge pull request #503 from dotnet-state-machine/docs/contributing

05d4432

Add guide to contributing

fix: InternalTransitionAsyncIf guard parameters

b6a77a4

Represent async "entry actions from trigger" in the same way as the s…

f755ddf

…ync version. Fix bug where trigger information is missing from the StateMachine.GetInfo.

Fix spelling mistake "fireing" to "firing"

46d3883

Restore the newline at the end of ActionInfo.cs

1cbd658

Merge pull request #514 from leeoades/bugfix-StateMachineInfo.Initial…

a6343fc

…State.Transitions-throws StateMachineInfo.InitialState.Transitions throws if AddRelationships not called

Merge pull request #512 from leeoades/fix-spelling-mistake-firing

22149f4

Fix spelling mistake "fireing" to "firing"

Implemented an example for an alarm.

8c03b2b

Merge pull request #511 from leeoades/bugfix-async-entry-actions-lack…

83bae7a

…-trigger-information Trigger information is missing for OnEntryFromAsync

Add an option to retain the synchronization context

5775438

Make specifying whether to retain the sync context on StateRepresenta…

e465b90

…tion mandatory

Specify whether to retain the sync context on StateRepresentation eve…

cefd21c

…rywhere within StateMachine

Also apply the sync context to a sync action internal trigger

c9ffd2c

Make test clearer

4625bcd

Added comments

1a185a7

Remove unused using declarations

a5a35ca

Added documentation to the README

ce95223

Further documentation of the tests

b2b3a40

Update example apps to net6.0

12e0b11

Fix typo

487842c

mclift and others added 14 commits June 2, 2023 16:19

Merge pull request #510 from teal-inc/lipatov/850-internal-transition…

57c68f2

…-async-if fix: InternalTransitionAsyncIf guard parameters

Restore and deprecate old InternalTransitionAsyncIf signatures.

c5ad663

Merge pull request #516 from celloza/celloza/alarmexample

0ba05aa

Implemented an example for an alarm

bugfix: Execute OnEntryFromAsync actions asynchronously

2ab545b

Throw InvalidOperationException when firing async action synchronously.

5bcedd6

Merge pull request #524 from pentp/obsolete-targets

22e29cd

Remove obsolete TargetFrameworks

Merge pull request #532 from mclift/bugfix/OnEntryFromAsync-InvalidOp…

b45b999

…erationException Bugfix: execute OnEntryFromAsync actions from FireAsync

Merge pull request #530 from dotnet-state-machine/850-internal-transi…

dc70a9d

…tion-async-if fix: InternalTransitionAsyncIf guard parameters (update)

Added FireAsync(TriggerWithParameters, params object[]) overload

63c8d51

This is async counterpart to existing Fire(TriggerWithParameters, params object[]) method. Required for firing triggers with more than 3 parameters asynchronously.

In the case of a superstate having a trigger that moves the state to …

f9b291b

…a substate, if the machine is already in that substate then the entry action shouldn't trigger again

Update README.md

1f9a302

Merge pull request #545 from jafin/fix/readme-link

e88e6eb

docs: Update README.md dead link for simplestatemachine

Merge pull request #544 from hooligan495/bugfix/543_prevent_reentry

99e49a8

In the case of a superstate having a trigger that moves the state to …

Release 5.14.0

996bb50

mclift requested review from crozone and HenningNT November 8, 2023 16:48

mclift added 3 commits November 9, 2023 12:22

Bump date in CHANGELOG.md

d1f08d6

Fix typo in CHANGELOG.md

bdcf10f

Bump date in CHANGELOG.md

3cf3106

mclift added 2 commits November 13, 2023 14:50

Merge pull request #536 from DeepakParamkusam/fire-async-param

7a35aaf

Added FireAsync(TriggerWithParameters, params object[]) overload

Added PR to ChangeLog; bumped date.

e28496c

HenningNT approved these changes Nov 13, 2023

View reviewed changes

crozone approved these changes Nov 14, 2023

View reviewed changes

Bump date in CHANGELOG

b936479

mclift merged commit 4a4ac06 into master Nov 14, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 5.14.0 #548

Release 5.14.0 #548

mclift commented Nov 8, 2023

crozone commented Nov 13, 2023

mclift commented Nov 13, 2023

HenningNT left a comment

HenningNT commented Nov 13, 2023

crozone commented Nov 14, 2023

mclift commented Nov 14, 2023

Release 5.14.0 #548

Release 5.14.0 #548

Conversation

mclift commented Nov 8, 2023

crozone commented Nov 13, 2023

mclift commented Nov 13, 2023

HenningNT left a comment

Choose a reason for hiding this comment

HenningNT commented Nov 13, 2023

crozone commented Nov 14, 2023

mclift commented Nov 14, 2023