Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript-fabbrica plugin in doc #9694

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

mizdra
Copy link
Contributor

@mizdra mizdra commented Oct 2, 2023

Description

I have created a plugin to help create mock data for GraphQL responses.

This plugin is very similar to graphql-codegen-typescript-mock-data. However, it allows for a more flexible factory to be defined, as the mock data factory can be defined programmatically.

I would like to include this in the documentation so that more people can see this plugin.

Type of change

  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

image

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

⚠️ No Changeset found

Latest commit: 41c3dd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saihaj
Copy link
Collaborator

saihaj commented Oct 12, 2023

hey @mizdra can you please rebase?

@saihaj saihaj added the waiting-for-answer Waiting for answer from author label Oct 12, 2023
@mizdra mizdra force-pushed the add-graphql-fabbrica-docs branch from 3498557 to 41c3dd7 Compare October 14, 2023 07:45
@mizdra
Copy link
Contributor Author

mizdra commented Oct 14, 2023

I rebased it. And I tested that http://localhost:3000/plugins/typescript/typescript-fabbrica can still be accessed :)

@mizdra mizdra requested a review from saihaj October 18, 2023 14:17
Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@saihaj saihaj removed the waiting-for-answer Waiting for answer from author label Oct 23, 2023
@saihaj saihaj merged commit 80e4a5b into dotansimha:master Oct 23, 2023
12 of 13 checks passed
@mizdra mizdra deleted the add-graphql-fabbrica-docs branch October 24, 2023 02:57
@mizdra
Copy link
Contributor Author

mizdra commented Oct 24, 2023

Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants