perf(watcher): ignore events in .git directory
#9556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67ab4f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dotansimha
approved these changes
Jul 17, 2023
n1ru4l
approved these changes
Jul 18, 2023
saihaj
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like files under
.git/**are tracked by@parcel/watcherwhen callinggenerate({..., watch: true}).This PR adds a small change to ignore the well-known
.gitdirectory by default.For example, from changing 1 tracked file a few times, it gets many events from
.git. Thefsmonitor--daemonchanges come from Git's fs monitor and are unrelated to the app. I've added a logger to show this inparcelWatcher.subscribe, and only the first two lines are relevant to the app: