Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: omit unused input/enum types when onlyOperationTypes is enabled #10164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathanregner
Copy link

@nathanregner nathanregner commented Oct 5, 2024

Description

When generating types with onlyOperationTypes: true, unused input types and enums will no longer be generated.

Related #9665

Type of change

  • Bug fix (non-breaking change which fixes an issue)
    • Arguably, this is how onlyOperationTypes should behave
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • On the other hand, it could technically break consumers that import unused types elsewhere in their codebase

Screenshots/Sandbox (if appropriate/relevant):

How Has This Been Tested?

  • Added unit tests
  • Regenerated example projects
  • Tested on a large (non-public, sorry) schema of 10000+ lines where only a small subset is consumed by operations.

Test Environment:

  • OS: Linux/MacOS
  • NodeJS: 20

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Oct 5, 2024

⚠️ No Changeset found

Latest commit: 577a68d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nathanregner nathanregner marked this pull request as ready for review October 7, 2024 23:39
@valerii-link
Copy link

Arguably, this is how onlyOperationTypes should behave

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants