fix assigning identifier overrides llvm alloca

dosisod · Oct 20, 2020 · e5e3b99 · e5e3b99
1 parent f5e268b
commit e5e3b99
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/skull/llvm/ast.c b/skull/llvm/ast.c
@@ -610,11 +610,13 @@ void llvm_assign_identifier(Variable *const var, const AstNode *const node) {
 		PANIC(FMT_ERROR(ERR_TYPE_MISMATCH, { .type = var->type }));
 	}
 
-	var->alloca = LLVMBuildAlloca(
-		builder,
-		var->type->llvm_type(),
-		c32stombs(var->name)
-	);
+	if (!var->alloca) {
+		var->alloca = LLVMBuildAlloca(
+			builder,
+			var->type->llvm_type(),
+			c32stombs(var->name)
+		);
+	}
 
 	LLVMValueRef load = LLVMBuildLoad2(
 		builder,

diff --git a/test/sh/_reassign_keep_var.sk.ll b/test/sh/_reassign_keep_var.sk.ll
@@ -0,0 +1,10 @@
+; ModuleID = './test/sh/reassign_keep_var.sk'
+source_filename = "./test/sh/reassign_keep_var.sk"
+
+define i64 @main() {
+entry:
+  %x = alloca i64
+  store i64 0, i64* %x
+  %0 = load i64, i64* %x
+  store i64 %0, i64* %x
+}
diff --git a/test/sh/reassign_keep_var.sk b/test/sh/reassign_keep_var.sk
@@ -0,0 +1,3 @@
+mut x := 0
+
+x = x