Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sim name logging #216

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Sim name logging #216

merged 5 commits into from
Jun 21, 2024

Conversation

marvin-steinke
Copy link
Contributor

@marvin-steinke marvin-steinke commented Jun 19, 2024 •
edited
Loading

Now the names of the Actors and Controllers are displayed when their sims start:

2024-06-19 12:21:39.476 | INFO     | mosaik.scenario:start:311 - Starting "Actor" as "ComputingSystem-0" ...
2024-06-19 12:21:39.477 | INFO     | mosaik.scenario:start:311 - Starting "Actor" as "solar_panel" ...
2024-06-19 12:21:39.478 | INFO     | mosaik.scenario:start:311 - Starting "Aggregator" as "Aggregator-0" ...
2024-06-19 12:21:39.479 | INFO     | mosaik.scenario:start:311 - Starting "Controller" as "Monitor-0" ...
2024-06-19 12:21:39.479 | INFO     | mosaik.scenario:start:311 - Starting "Grid" as "Grid-0" ...
2024-06-19 12:21:39.480 | INFO     | mosaik.scenario:run:651 - Starting simulation.
100%|██████████| 86400/86400 [00:00<00:00, 86984.19steps/s]
2024-06-19 12:21:40.476 | INFO     | mosaik.scenario:run:708 - Simulation finished successfully.

old:

2024-04-22 11:32:52.325 | INFO     | mosaik.scenario:start:280 - Starting "Actor" as "Actor-0" ...
2024-04-22 11:32:52.326 | INFO     | mosaik.scenario:start:280 - Starting "Actor" as "Actor-1" ...
2024-04-22 11:32:52.327 | INFO     | mosaik.scenario:start:280 - Starting "Aggregator" as "Aggregator-0" ...
2024-04-22 11:32:52.327 | INFO     | mosaik.scenario:start:280 - Starting "Controller" as "Controller-0" ...
2024-04-22 11:32:52.328 | INFO     | mosaik.scenario:start:280 - Starting "Grid" as "Grid-0" ...
2024-04-22 11:32:52.330 | INFO     | mosaik.scenario:run:598 - Starting simulation.
100%|██████████| 86400/86400 [00:00<00:00, 130816.03steps/s]
2024-04-22 11:32:52.993 | INFO     | mosaik.scenario:run:646 - Simulation finished successfully.
  • closes Display Sim Name for INFO Level Logging #180
  • the sim_id param of mosaik.world.start() that makes this possible is only available as of Mosaik 3.3 -> bumped version
  • turned off new greeting message that comes since that version
  • do we want our own ascii greeting message?

@marvin-steinke marvin-steinke changed the base branch from main to actor_interface June 19, 2024 10:30
@marvin-steinke marvin-steinke marked this pull request as ready for review June 19, 2024 10:31
@marvin-steinke marvin-steinke requested review from kilianp14 and birnbaum and removed request for kilianp14 June 19, 2024 10:31
kilianp14
kilianp14 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@kilianp14 kilianp14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marvin-steinke marvin-steinke merged commit 8505139 into actor_interface Jun 21, 2024
4 checks passed
@marvin-steinke marvin-steinke deleted the sim-name_logging branch June 21, 2024 09:28
@marvin-steinke marvin-steinke mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilianp14 kilianp14 kilianp14 approved these changes

@birnbaum birnbaum Awaiting requested review from birnbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display Sim Name for INFO Level Logging
2 participants
@marvin-steinke @kilianp14