Changed > to >= for Starting Index #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilianp14
reviewed
Oct 18, 2023
I see. The example in the docstring also relfects this behaviour. I think we should make this more clear since python convention for start and end point (eg for lists) is that the start is included but the end point is not. |
|
I wrote it explicitly in the docstring now in #144 |
|
How do we want to handle the case when we want a forecast from x to y but x is the first value of the dataframe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I want a forecast from time point x to y, I'd like for x to also show up in the forecast and not the next value after x, right?