Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash for incompatible hubs #819

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Fix crash for incompatible hubs #819

merged 1 commit into from
Jan 1, 2024

Conversation

dorssel
Copy link
Owner

@dorssel dorssel commented Dec 31, 2023

Fixes #809

Copy link
Contributor

github-actions bot commented Dec 31, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 8 0 0.02s
✅ BASH bash-exec 1 0 0.0s
✅ BASH shellcheck 1 0 0.06s
✅ BASH shfmt 1 0 0.0s
✅ EDITORCONFIG editorconfig-checker 134 0 0.78s
✅ JSON eslint-plugin-jsonc 4 0 0.83s
✅ JSON jsonlint 4 0 0.16s
✅ JSON prettier 4 0 0.41s
✅ JSON v8r 4 0 2.72s
✅ MARKDOWN markdownlint 3 0 0.52s
✅ MARKDOWN markdown-link-check 3 0 5.87s
✅ MARKDOWN markdown-table-formatter 3 0 0.27s
✅ REPOSITORY checkov yes no 11.8s
✅ REPOSITORY gitleaks yes no 1.98s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY grype yes no 12.85s
✅ REPOSITORY secretlint yes no 0.96s
✅ REPOSITORY trivy yes no 5.72s
✅ REPOSITORY trivy-sbom yes no 2.46s
✅ REPOSITORY trufflehog yes no 5.15s
✅ XML xmllint 14 0 0.01s
✅ YAML prettier 13 0 1.35s
✅ YAML v8r 13 0 11.34s
✅ YAML yamllint 13 0 0.3s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Dec 31, 2023

Test Results

2 907 tests  +177   2 907 ✅ +177   7s ⏱️ -1s
    1 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ❌ ±  0 

Results for commit bc752b8. ± Comparison against base commit c76e3e7.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (c76e3e7) 42.07% compared to head (bc752b8) 42.06%.

Files Patch % Lines
Usbipd/CommandHandlers.cs 0.00% 12 Missing ⚠️
Usbipd/ConfigurationManager.cs 0.00% 6 Missing ⚠️
Usbipd/Program.cs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   42.07%   42.06%   -0.02%     
==========================================
  Files          32       32              
  Lines        2733     2741       +8     
  Branches      390      400      +10     
==========================================
+ Hits         1150     1153       +3     
- Misses       1547     1552       +5     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorssel dorssel merged commit e1627b2 into master Jan 1, 2024
10 checks passed
@dorssel dorssel deleted the incompatible_hubs branch January 1, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exeption in WSL list
1 participant