Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LogCursor.execute when it uses default param=None #37

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Support LogCursor.execute when it uses default param=None #37

merged 1 commit into from
Oct 2, 2024

Conversation

dominictarro
Copy link
Owner

Closes #36

Uses the provided value if it evaluates to true, an empty dictionary otherwise.

@dominictarro dominictarro added the bug Something isn't working label Oct 2, 2024
@dominictarro dominictarro requested a review from ybryzTE October 2, 2024 15:42
@dominictarro dominictarro self-assigned this Oct 2, 2024
ybryzTE
ybryzTE approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ybryzTE ybryzTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dominictarro dominictarro merged commit 681d91c into main Oct 2, 2024
4 checks passed
@dominictarro dominictarro deleted the fix-none-param branch October 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybryzTE ybryzTE ybryzTE approved these changes

Assignees

@dominictarro dominictarro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obfuscate params errors out when params is None
2 participants
@dominictarro @ybryzTE