Optimize syncing logic to handle large outpoint sets #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rileystephens28
commented
Nov 27, 2024
•
rileystephens28
commented
- Use map for Qi wallet available outpoints
- Improve efficiency of syncing request batching
- Minor bug fixes
alejoacosta74
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Qi address derivation tests are failing. Mainly due to :
"lastSyncBlock"property not found inQiAddressInfo(this is expected, unit test data needs to be updated)- Address status expected is
"UNUSED"but got"UNKNOWN". Is this expected?
[ fail(1): derives external addresses correctly - External address mismatch for zone 0x00, expected: {"pubKey":"0x02be08725a5cef5a8eb4bf27b3f0e4d256663e44c25db8e9705aff27ee322f3384","address":"0x009f1545923a5A1052Aa162F858e2b925863Cd3D","index":385,"change":false,"zone":"0x00","status":"UNUSED","derivationPath":"BIP44:external","account":0}, derived: {"address":"0x009f1545923a5A1052Aa162F858e2b925863Cd3D","pubKey":"0x02be08725a5cef5a8eb4bf27b3f0e4d256663e44c25db8e9705aff27ee322f3384","account":0,"index":385,"change":false,"zone":"0x00","status":"UNKNOWN","derivationPath":"BIP44:external","lastSyncedBlock":null} ]
rileystephens28
commented
Nov 27, 2024
There was a problem hiding this comment.
Qi address derivation tests are failing. Mainly due to :
"lastSyncBlock"property not found inQiAddressInfo(this is expected, unit test data needs to be updated)- Address status expected is
"UNUSED"but got"UNKNOWN". Is this expected?[ fail(1): derives external addresses correctly - External address mismatch for zone 0x00, expected: {"pubKey":"0x02be08725a5cef5a8eb4bf27b3f0e4d256663e44c25db8e9705aff27ee322f3384","address":"0x009f1545923a5A1052Aa162F858e2b925863Cd3D","index":385,"change":false,"zone":"0x00","status":"UNUSED","derivationPath":"BIP44:external","account":0}, derived: {"address":"0x009f1545923a5A1052Aa162F858e2b925863Cd3D","pubKey":"0x02be08725a5cef5a8eb4bf27b3f0e4d256663e44c25db8e9705aff27ee322f3384","account":0,"index":385,"change":false,"zone":"0x00","status":"UNKNOWN","derivationPath":"BIP44:external","lastSyncedBlock":null} ]
Yes, this is intended. I just address status from "UNUSED" to "UNKNOWN" immediately after derivation as this better represents the status.
rileystephens28
force-pushed
the
syncing-improvements
branch
from
e1a717e to
4d667f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.