Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method visibility #215

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Change method visibility #215

merged 11 commits into from
Jun 25, 2024

Conversation

Juuddi
Copy link
Contributor

@Juuddi Juuddi commented Jun 24, 2024

No description provided.

@Juuddi Juuddi changed the title Change all @private to @ignore Change method visibility Jun 24, 2024
@Juuddi Juuddi requested a review from rileystephens28 June 24, 2024 20:45
Copy link
Member

@rileystephens28 rileystephens28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just need to address a few duplicated statements and tags in jsdocs.

src/abi/abi-coder.ts Outdated Show resolved Hide resolved
src/providers/abstract-provider.ts Show resolved Hide resolved
src/providers/provider-browser.ts Show resolved Hide resolved
src/wallet/qi-hdwallet.ts Outdated Show resolved Hide resolved
src/wallet/qi-hdwallet.ts Outdated Show resolved Hide resolved
@Juuddi Juuddi requested a review from rileystephens28 June 25, 2024 18:24
@rileystephens28 rileystephens28 merged commit 3a68b4b into master Jun 25, 2024
@rileystephens28 rileystephens28 deleted the ignore-docs branch July 11, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants