New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From fallback #200

Merged

rileystephens28 merged 3 commits into master from from-fallback

Jun 17, 2024

Member

rileystephens28 commented Jun 17, 2024

When signing a tx with a BaseWallet or Wallet instance, fallback to populating tx.from field with wallet address
Remove Qi logic from AbstractSigner because the AbstractSigner is only for ECDSA (aka Quai not Qi)
Check that the from address on a QuaiTransaction instance is actually a valid Quai address

rileystephens28 added 3 commits

June 17, 2024 13:50


          Fallback to wallet address when populating tx in signTransaction

b9e3670


          Remove Qi logic

6fa8954


          Better from address validation

e859701

alejoacosta74 approved these changes

View reviewed changes

Contributor

alejoacosta74 left a comment

Looks good

rileystephens28 merged commit 7e1e755 into master

rileystephens28 deleted the from-fallback branch

June 20, 2024 21:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet