Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended key #176

Closed
wants to merge 4 commits into from
Closed

Extended key #176

wants to merge 4 commits into from

Conversation

robertlincecum
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this file from the PR, seems like it was left over from @rileystephens28's file structure rework

Comment on lines +227 to +238
const myKey = encodeBase58Check(
concat([
'0x0488ADE4',
zpad(this.depth, 1),
'0x' + zpad(this.depth, 2),
this.accountFingerprint ?? '',
zpad(this.index, 4),
'0x' + zpad(this.index, 4),
this.chainCode,
concat(['0x00', this.privateKey]),
]),
);
return myKey;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are planning to revert this HDWallet class back to the original ethers HDNodeWallet class lets plan to move to these fixes over after that. I will keep this PR open until then.

@rileystephens28
Copy link
Member

Closing as this fix was addressed in #180.

@rileystephens28 rileystephens28 deleted the extended-key branch July 11, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants