-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended key #176
Extended key #176
Conversation
src.ts/wallet/quai-hdwallet.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this file from the PR, seems like it was left over from @rileystephens28's file structure rework
const myKey = encodeBase58Check( | ||
concat([ | ||
'0x0488ADE4', | ||
zpad(this.depth, 1), | ||
'0x' + zpad(this.depth, 2), | ||
this.accountFingerprint ?? '', | ||
zpad(this.index, 4), | ||
'0x' + zpad(this.index, 4), | ||
this.chainCode, | ||
concat(['0x00', this.privateKey]), | ||
]), | ||
); | ||
return myKey; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are planning to revert this HDWallet class back to the original ethers HDNodeWallet class lets plan to move to these fixes over after that. I will keep this PR open until then.
67d00b3
to
ffee0ce
Compare
Closing as this fix was addressed in #180. |
No description provided.