Mixcase checksum assertion #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoacosta74
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
No comments. Looks good to me.
A quick test shows the expected error when passing an address with the wrong checksum:
❯ npx hardhat run scripts/test-mixcase.js --network cyprus1 10:11:31
from: 0x00539bc2ce3ed0fd039c582cb700ef5398bb0491
to: 0x00539bc2ce3ed0fd039c582cb700ef5398bb0491
TypeError: invalid address checksum (argument="address", value="0x00539bc2ce3ed0fd039c582cb700ef5398bb0491", code=INVALID_ARGUMENT, version=0.0.1)
{
code: 'INVALID_ARGUMENT',
argument: 'address',
value: '0x00539bc2ce3ed0fd039c582cb700ef5398bb0491',
shortMessage: 'invalid address checksum'
}
rileystephens28
force-pushed
the
mixcase-checksum-assertion
branch
from
c696899 to
9a6edc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose new
validateAddressmethod and force users to input already valid mixed case checksummed addresses