Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for legacy RPC calls #2386

Merged
merged 20 commits into from
Dec 16, 2024
Merged

Add support for legacy RPC calls #2386

merged 20 commits into from
Dec 16, 2024

Conversation

jdowning100
Copy link
Contributor

No description provided.

@jdowning100 jdowning100 changed the base branch from main to goldenage November 27, 2024 19:06
wizeguyy
wizeguyy previously approved these changes Dec 2, 2024
View reviewed changes
Djadih
Djadih requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Djadih Djadih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing a couple of tests

Djadih
Djadih reviewed Dec 4, 2024
View reviewed changes
internal/quaiapi/quai_api.go Outdated Show resolved Hide resolved
Djadih
Djadih reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Djadih Djadih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise completed review

@jdowning100 jdowning100 force-pushed the legacy-rpc branch 2 times, most recently from cda63df to f8bed80 Compare December 4, 2024 21:41
@jdowning100
Updated quai API transactionArgs for Qi TxIn and TxOut
f90657f
@jdowning100
EstimateGas ignores provided nonce and sets correct nonce from state
134eba7
@jdowning100
UTXO indexer bugfix: don't load outpoints for address that shouldn't …
a1c5015 
…exist yet
@jdowning100
getTransactionByHash returns Qi tx from pool if it exists
12c0f0a
@jdowning100
getBalance does not return locked Qi UTXOs and added getLockedBalance…
02c2da9 
… to RPC API
@jdowning100
Added Quai lockups to indexer and added GetLockupsByAddress and GetLo…
9dcc2e9 
…ckedBalance
@jdowning100
Added --node.reindex flag that reindexes the UTXO/lockup indexer from…
ea73a8c 
… genesis before starting the node
@jdowning100
Feat: Add chain indexer validation logic and node.validate-indexer flag
8aa8ce0
@jdowning100
Fixed indexer so consensus UTXO set is not read from
fcc7421
@jdowning100
Added quai_getOutpointDeltasForAddressesInRange API
2b401c6
@jdowning100
Reindex bloom filters
2a6144b
@jdowning100
Fix ethclient
cab804b
@jdowning100 jdowning100 merged commit 1124fdc into dominant-strategies:goldenage Dec 16, 2024
8 checks passed
@jdowning100 jdowning100 deleted the legacy-rpc branch December 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeguyy wizeguyy wizeguyy approved these changes

@Djadih Djadih Djadih approved these changes

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

@gameofpointers gameofpointers Awaiting requested review from gameofpointers gameofpointers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdowning100 @Djadih @wizeguyy