Implement pubkey compression/decompression in TxIns protobuf encoding/decoding #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoacosta74
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
wizeguyy
requested changes
Sep 30, 2024
alejoacosta74
force-pushed
the
pubkey-compressed
branch
2 times, most recently
from
88c087c to
4195671
Compare
alejoacosta74
changed the title
wizeguyy
requested changes
Oct 1, 2024
alejoacosta74
force-pushed
the
pubkey-compressed
branch
from
4195671 to
f6415ec
Compare
wizeguyy
previously approved these changes
Oct 2, 2024
jdowning100
previously requested changes
Oct 2, 2024
There was a problem hiding this comment.
This PR is not complete. You need to also compress/decompress the pubkey in RPCTxIn and TxInJSON structs and ensure that it is encoded properly in quai_getTransactionByHash
If we want to fully support compressed public keys, someone must also make appropriate changes in quais.js to support the compressed public key type and ensure that it is compressed before sending to the node
alejoacosta74
changed the title
alejoacosta74
force-pushed
the
pubkey-compressed
branch
from
f6415ec to
64e3bab
Compare
gameofpointers
requested changes
Oct 9, 2024
gameofpointers
previously approved these changes
Oct 10, 2024
alejoacosta74
dismissed stale reviews from gameofpointers and wizeguyy
via
c486917
alejoacosta74
force-pushed
the
pubkey-compressed
branch
from
64e3bab to
c486917
Compare
alejoacosta74
dismissed
jdowning100’s stale review
It was agreed to handle the JSON RPC conversion on a separate commit
gameofpointers
approved these changes
Oct 10, 2024
Djadih
approved these changes
Oct 10, 2024
wizeguyy
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.