Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: always at least allocate empty peer map #1745

Merged
merged 1 commit into from
May 15, 2024

Conversation

wizeguyy
Copy link
Member

Resolves #1744

@wizeguyy wizeguyy self-assigned this May 15, 2024
@Djadih
Copy link
Contributor

Djadih commented May 15, 2024

Still happening
ERROR [05-15|10:56:36.871] Go-Quai Panicked error="assignment to entry in nil map" stacktrace="goroutine 3985 [running]:\nruntime/debug.Stack()\n\t/usr/lib/go/src/runtime/debug/stack.go:24 +0x6b\ngithub.com/dominant-strategies/go-quai/p2p/node.(*P2PNode).requestFromPeers.func1.1()\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/api.go:125 +0x145\npanic({0x20ac9e0?, 0x26cc730?})\n\t/usr/lib/go/src/runtime/panic.go:770 +0x136\nmaps.Copy[...](0x0, 0xc16c962d20)\n\t/usr/lib/go/src/maps/maps.go:55 +0xcf\ngithub.com/dominant-strategies/go-quai/p2p/node/peerManager.(*BasicPeerManager).queryDHT(0xc000139f00, 0xc16c951440, 0x0, 0x3)\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/peerManager/peerManager.go:358 +0x3e5\ngithub.com/dominant-strategies/go-quai/p2p/node/peerManager.(*BasicPeerManager).GetPeers(0xc000139f00, 0xc16c951440, 0x0)\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/peerManager/peerManager.go:341 +0xf3\ngithub.com/dominant-strategies/go-quai/p2p/node.(*P2PNode).requestFromPeers.func1()\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/api.go:130 +0x133\ncreated by github.com/dominant-strategies/go-quai/p2p/node.(*P2PNode).requestFromPeers in goroutine 3984\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/api.go:120 +0x165\n"

@Djadih
Copy link
Contributor

Djadih commented May 15, 2024

Still happening ERROR [05-15|10:56:36.871] Go-Quai Panicked error="assignment to entry in nil map" stacktrace="goroutine 3985 [running]:\nruntime/debug.Stack()\n\t/usr/lib/go/src/runtime/debug/stack.go:24 +0x6b\ngithub.com/dominant-strategies/go-quai/p2p/node.(*P2PNode).requestFromPeers.func1.1()\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/api.go:125 +0x145\npanic({0x20ac9e0?, 0x26cc730?})\n\t/usr/lib/go/src/runtime/panic.go:770 +0x136\nmaps.Copy[...](0x0, 0xc16c962d20)\n\t/usr/lib/go/src/maps/maps.go:55 +0xcf\ngithub.com/dominant-strategies/go-quai/p2p/node/peerManager.(*BasicPeerManager).queryDHT(0xc000139f00, 0xc16c951440, 0x0, 0x3)\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/peerManager/peerManager.go:358 +0x3e5\ngithub.com/dominant-strategies/go-quai/p2p/node/peerManager.(*BasicPeerManager).GetPeers(0xc000139f00, 0xc16c951440, 0x0)\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/peerManager/peerManager.go:341 +0xf3\ngithub.com/dominant-strategies/go-quai/p2p/node.(*P2PNode).requestFromPeers.func1()\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/api.go:130 +0x133\ncreated by github.com/dominant-strategies/go-quai/p2p/node.(*P2PNode).requestFromPeers in goroutine 3984\n\t/home/hdjadi/Github/dominant-strategies/go-quai/p2p/node/api.go:120 +0x165\n"

Issue likely not related to this fix.

@wizeguyy wizeguyy merged commit f546733 into dominant-strategies:main May 15, 2024
6 of 7 checks passed
@wizeguyy wizeguyy deleted the fix-nil-map branch May 15, 2024 17:43
Copy link
Contributor

@jdowning100 jdowning100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nil Peermap
4 participants