Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix and changes from garden env testing #1665

Merged
merged 11 commits into from
Apr 26, 2024
Merged

bugfix and changes from garden env testing #1665

merged 11 commits into from
Apr 26, 2024

Conversation

gameofpointers
Copy link
Contributor

No description provided.

Djadih
Djadih requested changes Apr 25, 2024
View reviewed changes
p2p/pubsubManager/gossipsub.go Outdated Show resolved Hide resolved
@gameofpointers gameofpointers force-pushed the genallocs branch 2 times, most recently from 706656a to 22305db Compare April 25, 2024 18:51
jdowning100
jdowning100 reviewed Apr 25, 2024
View reviewed changes
core/genesis.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Apr 25, 2024
View reviewed changes
core/tx_pool.go Outdated Show resolved Hide resolved
@gameofpointers gameofpointers force-pushed the genallocs branch 2 times, most recently from 949e600 to 8601cf2 Compare April 25, 2024 19:22
@gameofpointers gameofpointers marked this pull request as draft April 25, 2024 19:24
@gameofpointers gameofpointers marked this pull request as ready for review April 25, 2024 19:25
jdowning100
jdowning100 previously approved these changes Apr 25, 2024
View reviewed changes
Djadih
Djadih reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Djadih Djadih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are logical, however something prevented this branch from mining recently

wizeguyy
wizeguyy requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this violates qip-0008 expansion rules

@wizeguyy wizeguyy self-requested a review April 26, 2024 14:31
@gameofpointers gameofpointers merged commit d021b8f into dominant-strategies:main Apr 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdowning100 jdowning100 jdowning100 left review comments

@wizeguyy wizeguyy wizeguyy approved these changes

@Djadih Djadih Djadih approved these changes

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gameofpointers @Djadih @jdowning100 @wizeguyy @kiltsonfire @alanorwick