Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quaiclient tests #1174

Closed

Conversation

didaunesp
Copy link
Contributor

@dominant-strategies/core-dev

eth/backend.go Outdated Show resolved Hide resolved
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch 2 times, most recently from dc7e8cc to 75801a1 Compare October 10, 2023 18:42
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch 2 times, most recently from 903e256 to aadafc4 Compare October 11, 2023 15:09
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch 2 times, most recently from 7933319 to 2353a4b Compare October 24, 2023 17:09
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch 2 times, most recently from cc8a8e3 to 9180a2a Compare October 27, 2023 16:00
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch 3 times, most recently from 98f359c to ba38e11 Compare November 17, 2023 16:23
@didaunesp didaunesp marked this pull request as ready for review November 17, 2023 16:26
eth/backend.go Show resolved Hide resolved
eth/backend.go Show resolved Hide resolved
@gameofpointers gameofpointers self-requested a review November 22, 2023 16:28
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch 2 times, most recently from afbef4b to 91112c4 Compare November 29, 2023 14:28
Copy link
Contributor

@gameofpointers gameofpointers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop this commit

core/slice.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gameofpointers gameofpointers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general what is the status of the Tests?

core/slice.go Outdated Show resolved Hide resolved
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch 3 times, most recently from e0246a9 to faceed1 Compare December 11, 2023 15:53
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch from faceed1 to e5b40bc Compare December 20, 2023 13:39
eth/backend.go Outdated Show resolved Hide resolved
quaiclient/quaiclient.go Outdated Show resolved Hide resolved
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch from aee1f42 to 570f40b Compare December 22, 2023 16:16
@didaunesp didaunesp force-pushed the fix-quaiclient-tests branch from 7889cc8 to 4529096 Compare February 8, 2024 15:12
@wizeguyy
Copy link
Member

wizeguyy commented Mar 8, 2024

no more feature PRs to main. Retarget all work to goldenage

@wizeguyy wizeguyy closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants