This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
Update precompile addresses to be QIP2 compatible #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdowning100
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
wizeguyy
reviewed
Feb 1, 2024
wizeguyy
previously approved these changes
Feb 1, 2024
jdowning100
force-pushed
the
update-precompiles
branch
from
3d46f40 to
b93406a
Compare
gameofpointers
approved these changes
Feb 29, 2024
wizeguyy
reviewed
Feb 29, 2024
wizeguyy
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompile addresses are now in the format 0x[location-byte-prefix]000000000000000000000000000000000000[index-byte] where index-byte is the last byte of the precompile's original address in EVM. (1 is ecrecover, 2 is sha256, etc)
Basically, add the index byte to the location-specific zero address. The zero address is not a valid precompile.
This does still mean that we can have up to 255 precompiles, but we can hardfork to support 2 bytes for the index if we really need more than 255.